Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Django custom user compatible #5

Merged
merged 33 commits into from
Mar 10, 2021
Merged

Django custom user compatible #5

merged 33 commits into from
Mar 10, 2021

Conversation

urtzai
Copy link
Contributor

@urtzai urtzai commented Jan 11, 2016

No description provided.

@urtzai
Copy link
Contributor Author

urtzai commented Jan 11, 2016

Needs to update migrations. Sorry...

@PiDelport PiDelport self-assigned this Jan 11, 2016
@PiDelport
Copy link
Member

What do you think about just using settings.AUTH_USER_MODEL directly, instead of introducing the voting.utils.user_model shim?

The only reason I can think of to have the compatibility module is for Django 1.4 compatibility, but I think we can probably drop that for the next release? (Django 1.4 is very old, and out of its extended support lifetime upstream.)

@PiDelport PiDelport added this to the 0.3 milestone Jan 18, 2016
@urtzai
Copy link
Contributor Author

urtzai commented Jan 18, 2016

I think that is a good idea. I agree with everything you say

@PiDelport
Replace MANIFEST.in with using setuptools_scm
96ceaeb
@PiDelport
Use setuptools rather than distutils.core
561818e
@PiDelport
Make Django dependency explicit (>=1.4, <1.9 for now)
b316834
@PiDelport
Simplify tox.ini, and update Python / Django versions
75e32ed 
This uses a generative envlist, and updates Python to 2.7 and 3.4.

The tests don't pass on Python 3.5 and Django 1.9 yet.
@PiDelport
Clean up .gitignore a bit
e28a234 
(This drops MANIFEST, which should no longer be generated.)
@PiDelport
Update Travis env list
3e0d316
@PiDelport
Copy link
Member

Cool. :)

Do you want to take a stab at updating this PR?

@PiDelport
(Whitespace)
891a678
@PiDelport
Switch to use_scm_version, drop voting.VERSION
362c8d0
@PiDelport
(Add 0.2 release date to changelog)
c891862
@PiDelport
Reorganise code into src/ and tests/ directories
82ed67d 
Use find_packages() in setup.py.

Drop Django 1.4 and 1.5 from automated tests.
@PiDelport
Move South migrations to south_migrations/
357ee27
@PiDelport
Add new initial Django migration
1658114
@PiDelport
Update deprecated Django imports
7ea05ab
@PiDelport
Run coverage with Django 1.8 LTS
e4b6c41
@PiDelport
Add explicit MIDDLEWARE_CLASSES to test_settings
0ad783c 
This silences the Django 1.7 warning.
@PiDelport
Add ROOT_URLCONF to test_settings
f806b0c
@PiDelport
Drop Dango 1.6, add Django 1.9
7f38b38
@PiDelport
Add "django-admin check" before the tests
a263d71
@PiDelport
Improve code coverage configuration and instructions
2438062 
Remove the "coverage" configuration from Tox, for now:
it does not really serve a compelling purpose,
and it's not as easy to get it to generate good reports.
@PiDelport
Fold installation instructions into README
b95a38e
@urtzai
Copy link
Contributor Author

urtzai commented Feb 10, 2016

Sorry... but I have lots of projects to manage and no enough time to manage more... Thank you for your offer

@seirl
Copy link

seirl commented Apr 6, 2017

The proper way is to use get_user_model() from django.contrib.auth.

Will this get merged in the near future?

@seirl seirl mentioned this pull request Apr 6, 2017
Closed
@PiDelport
Copy link
Member

Project update: Move to Jazzband, or retire? #13

@PiDelport PiDelport removed their assignment Mar 12, 2019
@jezdez jezdez merged commit f08537d into jazzband:master Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement update
Projects
None yet
Milestone
0.3
Development

Successfully merging this pull request may close these issues.
6 participants
@urtzai @PiDelport @seirl @jezdez @davidyuk @jatsu