make phonenumber plugin really a plugin

[jpaniagualaconich]

Description

Motivation and Context

Fixes #469, fixes #581.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1928748) 97.84% compared to head (98ec23c) 95.52%.

❗ Current head 98ec23c differs from pull request most recent head b1a874c. Consider uploading reports for the commit b1a874c to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #654      +/-   ##
==========================================
- Coverage   97.84%   95.52%   -2.32%     
==========================================
  Files          78       78              
  Lines        3384     3352      -32     
  Branches      384      377       -7     
==========================================
- Hits         3311     3202     -109     
- Misses         42      119      +77     
  Partials       31       31              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[claudep]

I had a quick look, looks very good overall. Generally I prefer having smaller commits for various reasons, notably as it's easier to spot regressions when they happen. Do you think it would be possible to split your commit in smaller ones, targeted on more granular changes?

[jpaniagualaconich]

@claudep then please check #656 #658 #660 #662 first.

Once they're merged we can continue with #666 and this one.

[claudep]

That's great, thanks so much. I'll review the individual patches ASAP.

[jpaniagualaconich]

@claudep I think I'll do a PR adding some skips in tests that expect the phonenumber plugin to be present and perhaps refactor some of them before going on with this PR. What do you think?

[claudep]

Feel free to make some more incremental PRs, even if it is for small things.