Fix: Error when setting table name with inherit #1196
Merged
+25
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error was thrown when table_name is set with inherit=True in base model. - add not inherited check jazzband#1195
- authors and changes docs updated
muneeb706
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1196 +/- ##
=======================================
Coverage 97.08% 97.08%
=======================================
Files 23 23
Lines 1271 1271
Branches 208 208
=======================================
Hits 1234 1234
Misses 19 19
Partials 18 18
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thank you for reviewing, I have added a test. |
theryanwalker
previously approved these changes
Aug 15, 2023
Now also compares the table name of the inherited (base) model, so that it's easier to see that the history table name is not inherited.
ddabble
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Looks good! Thank you, @muneeb706, and also @theryanwalker for reviewing :)
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error was thrown when
table_nameis set with inherit=True in base model.inherited check added in the condition where
table_nameis checked for updating db table name.Description
inherited flag argument in
create_history_modelmethod is used in the condition wheretable_nameis checked. Condition at line 301 ofsimple_history.modelsnow look like this:if not inherited and self.table_name is not None:Related Issue
Closes #1195.
Motivation and Context
I found this issue while looking for the solution of #1174.
In documentation it is not mentioned that table_name can't be used with inherit. It is implied that this should work, this inconsistency was the motivation.
How Has This Been Tested?
Ran tests locally using
runtests.pywith python (3.8,3.11) and django 4.1Types of changes
Checklist:
pre-commit runcommand to format and lint.AUTHORS.rstCHANGES.rst