Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for Python 3.13 #756

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Added support for Python 3.13 #756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,21 +36,26 @@ jobs:
- django-version: '4.2'
redis-version: 'latest'
python-version: '3.9'

# Django 5.1 and python 3.13 with latest redis
- django-version: '5.1'
redis-version: 'latest'
python-version: '3.13'

# latest Django with pre-release redis
- django-version: '5.1'
redis-version: 'master'
python-version: '3.12'
python-version: '3.13'

# latest redis with pre-release Django
- django-version: 'main'
redis-version: 'latest'
python-version: '3.12'
python-version: '3.13'

# pre-release Django and redis
- django-version: 'main'
redis-version: 'master'
python-version: '3.12'
python-version: '3.13'

steps:
- uses: actions/checkout@v4
Expand Down
1 change: 1 addition & 0 deletions changelog.d/756.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Added support for Python 3.13
7 changes: 5 additions & 2 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ classifiers =
Programming Language :: Python :: 3.10
Programming Language :: Python :: 3.11
Programming Language :: Python :: 3.12
Programming Language :: Python :: 3.13
Topic :: Software Development :: Libraries
Topic :: Utilities

Expand Down Expand Up @@ -60,9 +61,10 @@ envlist =
# tests against released versions
py{38,39}-dj{42}-redislatest
py{310,311,312}-dj{42,50,51}-redislatest
py313-dj51-redislatest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not do like on line 67?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line aims to add Python 3.13 (supported only by Django 5.1) and the latest Redis to the matrix. Not sure how it can be more like line 67, an example would be nice.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
py313-dj51-redislatest
py313-dj51-redis{latest,master}

and remove py313-dj51-redismaster from line 66

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. I can apply that, but there is contextual grouping between tests against released versions and tests against unreleased versions in that block. Do we want to change that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python3.13 is not yet supported by redis-py officially so I guess we can consider it unreleased 😄

# tests against unreleased versions
py311-dj51-redismaster
py311-djmain-redis{latest,master}
py313-dj51-redismaster
py313-djmain-redis{latest,master}

[gh-actions]
python =
Expand All @@ -71,6 +73,7 @@ python =
3.10: py310
3.11: py311
3.12: py312
3.13: py313

[gh-actions:env]
DJANGO =
Expand Down
Loading