Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum required version info in README.md #755

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

ulgens
Copy link
Member

@ulgens ulgens commented Oct 26, 2024

using min support version infos from trove classifiers

@ulgens ulgens force-pushed the update_docs_supported_versions branch from 1548857 to e250be7 Compare October 26, 2024 09:18
using min support version infos from trove classifiers and install_requires
@ulgens ulgens force-pushed the update_docs_supported_versions branch from e250be7 to 093b7fb Compare October 26, 2024 09:21
Copy link
Member

@WisdomPill WisdomPill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And good catch!

@ulgens
Copy link
Member Author

ulgens commented Oct 26, 2024

@WisdomPill Thank you 🌷 Am I free to merge this or is there any other step required?

@WisdomPill WisdomPill merged commit 07089ff into master Oct 26, 2024
37 checks passed
@WisdomPill WisdomPill deleted the update_docs_supported_versions branch October 26, 2024 09:48
@WisdomPill
Copy link
Member

In general I would say yes, but it's better to let maintainers or long time contributors approve PRs first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants