Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock added blocking parameter #752

Merged
merged 10 commits into from
Oct 20, 2024

Conversation

WisdomPill
Copy link
Member

@WisdomPill WisdomPill commented Oct 20, 2024

Fixes: #596

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 63.2%. Comparing base (f34935c) to head (673064a).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
tests/test_backend.py 0.0% 10 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #752     +/-   ##
========================================
- Coverage    63.3%   63.2%   -0.1%     
========================================
  Files          43      43             
  Lines        3215    3223      +8     
  Branches      244     244             
========================================
  Hits         2034    2034             
- Misses       1164    1172      +8     
  Partials       17      17             
Flag Coverage Δ
mypy 38.0% <13.4%> (-<0.1%) ⬇️
tests 90.5% <100.0%> (+0.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WisdomPill WisdomPill merged commit 67b47db into jazzband:master Oct 20, 2024
15 of 18 checks passed
@WisdomPill WisdomPill deleted the bugfix/596/lock_blocking_params branch October 20, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default client does not pass blocking kwarg through lock method
1 participant