Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing methods #721

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Add missing methods #721

wants to merge 13 commits into from

Conversation

LucianaAG
Copy link

Continuation of #654 PR. The previous left it halfway.

@LucianaAG
Copy link
Author

LucianaAG commented Jan 30, 2024 •
edited
Loading

@WisdomPill Can you tell why the checks are failling and how solver it? Also I would like know what is the purpose of what is inside the "Changelog.d" folder.

@WisdomPill
Copy link
Member

@LucianaAG you need to use Set from typing module because we still support older versions of python.

About changeling you need to create a file inside changelog.d with hit name 721.feature and as content a description of what this PR does, in this way the CHANGELOG file will be updated accordingly when we release and the release notes will have that info as well

WisdomPill
WisdomPill requested changes Feb 1, 2024
View reviewed changes
Copy link
Member

@WisdomPill WisdomPill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pointed out where changes are needed to fix errors in CI

django_redis/client/default.py Outdated
*keys,
version: Optional[int] = None,
client: Optional[Redis] = None,
) -> set:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to change this one to Set

django_redis/client/default.py Outdated
key: Any,
version: Optional[int] = None,
client: Optional[Redis] = None,
) -> set:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to change this one to Set

maybe it's not always a set, have you checked redis-py

django_redis/client/default.py Outdated
count: Optional[int] = None,
version: Optional[int] = None,
client: Optional[Redis] = None,
) -> Union[set, Any]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to change this one to Set

maybe it's not always a set, have you checked redis-py

django_redis/client/default.py Outdated
count: Optional[int] = None,
version: Optional[int] = None,
client: Optional[Redis] = None,
) -> Union[set, Any]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to change this one to Set

maybe it's not always a set, have you checked redis-py

django_redis/client/default.py Outdated
*keys,
version: Optional[int] = None,
client: Optional[Redis] = None,
) -> set:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to change this one to Set

django_redis/client/default.py Outdated
count: Optional[int] = None,
version: Optional[int] = None,
client: Optional[Redis] = None,
) -> set[Any]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to change this one to Set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WisdomPill WisdomPill WisdomPill requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucianaAG @WisdomPill