Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dill serializer #321

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

svenauhagen
Copy link

Hi,

this is a dill serializer.
I do need it because I use django model utils to track fields.
That plugin does not work with pickle but dill works on serializing models with it:

jazzband/django-model-utils#83

Best and thanks
Sven

@eyesee1
Copy link

eyesee1 commented Apr 24, 2018

dill needs to be added to requirements.txt

Add dill as requirement
@svenauhagen
Copy link
Author

done

@jdufresne
Copy link
Member

I think it would be good to add tests similar to the other serializers.

@niwinz
Copy link
Collaborator

niwinz commented Sep 29, 2018

Tests are mandatory for new features.

@svenauhagen
Copy link
Author

Hi I added some test for dill.
Let me know if that is the correct way of adding the tests for the project.

@peterbe
Copy link

peterbe commented Nov 16, 2018

If someone knows they want django-redis with dill they'd install it with pip install "django-redis[dill]". To make that work you'd just add to setup.py...:

  extras_require={
      'dill': ['dill'],
  },

@peterbe
Copy link

peterbe commented Nov 16, 2018

Can this PR also come with a change to the docs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants