Added Safari browser to web-push #687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new browser selection Safari
Added Safari, FirefoxV1, FarefoxV2 to default settings
Added Firefox 1, Firefox V2 to browser field selection
|
Looks good @Sergey-Yalovoy . If you rebase against master, I have fixed the failing test actions. |
|
Will this require a new migration? See: https://github.com/jazzband/django-push-notifications/blob/master/push_notifications/migrations/0008_webpush_add_edge.py |
|
As I understand, with #674 makes WP browser generic, so this PR won't be needed. |
|
Closing as this is addressed by #674 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have studied the problems with Safari and offer my solution.
I tested my solution in my project, it works great.