Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure mypy with django-stubs #383

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Configure mypy with django-stubs #383

merged 1 commit into from
Oct 19, 2023

Conversation

WhyNotHugo
Copy link
Member

This should help catch typing errors early.

tox.ini Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #383 (6a980bd) into main (93dc588) will decrease coverage by 0.12%.
Report is 2 commits behind head on main.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
- Coverage   78.54%   78.42%   -0.12%     
==========================================
  Files          29       29              
  Lines        1976     1979       +3     
  Branches      243      244       +1     
==========================================
  Hits         1552     1552              
- Misses        308      310       +2     
- Partials      116      117       +1     
Files Coverage Δ
payments/models.py 75.78% <50.00%> (ø)
payments/stripe/__init__.py 66.07% <50.00%> (-1.86%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

This allows mypy to do a lot of type-inference round django-related
code. Should improve how we handle typing errors.
@WhyNotHugo WhyNotHugo marked this pull request as ready for review October 19, 2023 17:46
@WhyNotHugo WhyNotHugo merged commit 30e05cc into main Oct 19, 2023
16 of 18 checks passed
@WhyNotHugo WhyNotHugo deleted the mypy branch January 27, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant