Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added captured amount to DummyProvider #382

Merged

Conversation

juanpsenn
Copy link
Contributor

I think that this would solve #374 bug, at least for a full captured amount.
Maybe in a future consider a more complex scenario like parcial captures 🤔

What do you think? Should this be optionally?

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #382 (9ab4050) into main (8455648) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #382      +/-   ##
==========================================
- Coverage   78.54%   78.51%   -0.03%     
==========================================
  Files          29       29              
  Lines        1976     1978       +2     
  Branches      243      243              
==========================================
+ Hits         1552     1553       +1     
- Misses        308      309       +1     
  Partials      116      116              
Files Coverage Δ
payments/dummy/__init__.py 84.90% <50.00%> (-1.37%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@WhyNotHugo WhyNotHugo merged commit 2c28dd4 into jazzband:main Oct 19, 2023
20 of 22 checks passed
@WhyNotHugo
Copy link
Member

Thanks!

@juanpsenn juanpsenn deleted the set-capture-amount-on-dummy-provider branch October 27, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants