Don't reinitialize a TEST_MIRROR (duplicate work) on REUSE_DB=1. #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using REUSE_DB=1 and a setup with more than one database, where the other databases point to the first one, using the TEST_MIRROR setting, Nose would sqlflush both databases. When there is lots of work or a slow link, running ALTER TABLE to reset the auto increment on all tables can take more than a few seconds. Before this fix, the whole process would be done a second time on the test-mirror database -- which is the same.
|
I'm sorry. I don't have time to find out how to write unit tests for this, this time. |
|
Is this the same issue as #236 ? |
|
@jwhitlock: No, I'm not experiencing any issues with the test_mirror db itself -- possibly because we don't run tests on the mirror, I haven't checked. This issue is just about double initialization of the (same) db. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using REUSE_DB=1 and a setup with more than one database, where the
other databases point to the first one, using the TEST_MIRROR setting,
Nose would sqlflush both databases.
When there is lots of work or a slow link, running ALTER TABLE to reset
the auto increment on all tables can take more than a few seconds.
Before this fix, the whole process would be done a second time on the
test-mirror database -- which is the same.