Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix previously unhandled case of expired invitation when multiple-sending #244

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix previously unhandled case of expired invitation when multiple-sending #244

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56eaf6c
fix unhandled case of expired invitation in multiple-send
userhuge Feb 27, 2024
2e0ac68
fix formatting
userhuge Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions invitations/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,15 @@ def post(self, request, *args, **kwargs):
try:
validate_email(invitee)
CleanEmailMixin().validate_invitation(invitee)
# ^as a read-only check it does not change old entries as needed:
invalid_invitations = Invitation.objects.all().exclude(
pk__in=Invitation.objects.all_valid()
)
target_invitation = invalid_invitations.filter(
email__iexact=invitee
)
if target_invitation:
target_invitation.get().delete() # email is unique, .get works
invite = Invitation.create(invitee)
except (ValueError, KeyError):
pass
Expand Down