-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Liveinternet #223
base: main
Are you sure you want to change the base?
Add Liveinternet #223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! If it works on your end.
Can you please add tests to make the implementation complete?
Take a look at the other modules, if you need inspiration. It's easy and quick to do.
Thank you! 👍
Co-authored-by: Peter Bittner <[email protected]>
Kind of implemented all the wishes 😊 |
Flake8 and isort found 3 minor issues, and some of your tests are failing. Can you fix that? |
I don't have a lot of time right now, so I can't. As soon as I'm free, if I don't forget, I'll fix it. |
It's all good, take your time. Your contribution is good on track at the moment. Unfortunately, it's necessary to satisfy some basic code quality metrics. There's not much missing, though, really. Thank you for your understanding! Maybe set yourself a reminder. ⏱️ |
Addition service Liveinternet. Several implementation options have been made as per the documentation: