-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hmc dev #7
base: master
Are you sure you want to change the base?
Hmc dev #7
Conversation
…nged OCC routine on line 91 to small letters
Hi @eelcovv. The pull request looks great. Thanks for testing cadmium on Windows. I'll be glad to accept this pull request, but it will be better to squash all the commits into a single commit. That way if we find any regressions in future, they will be easy to locate using git-bisect. (If you need any help with squashing, here's some git help https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History#Squashing-Commits) |
…need 0.17 for free cad. This is a no-go
Hi Jay3sh
Thanks for this excellent solid modeller tool. It looks very promissing to my project
However, I have installed your module under windows and had to do quite some fixed in order to get the examples running. It seems that some naming in the OCC are different.
Perhaps you could review my changes and see if they also apply under the linux version as well. Otherwise perhaps you could add a operating system check to switch between windows and linux. Everything I have changed in solid.py relates to different namings.
The only example I could not get going number 11 which now gives the error "Wrong number or type of arguments for overloaded function 'gp_XYZ_Coord'." Perhaps you can see what goes wrong.
The other example is the test-example which is using fontforge. I could never get this installed. So I have added a try/except in the source because otherwise you can not load the module in the first place. Now only the font related examples do not work if you don't have fontforge
Anyway, all other examples are working like a charme. I think this is a really handy module
Regards
Eelco