Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FloatPyCast for improved performance using lookup table #151

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vxst
Copy link

@vxst vxst commented May 18, 2024

Since there are only 256 values in float8 (whichever flavor), we can utilize a technique similar to the SBox in AES: pre-calculate the mapping for conversion and look it up when performing conversions.

As this project is for python, and (perhaps?) float8.h won't directly used by users, and if the user need to use float8.h, they might want more control(e.g. debug), so I implement the lookup table in FloatPyCast function.

Ref. #150

Copy link

google-cla bot commented May 18, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@vxst
Copy link
Author

vxst commented May 18, 2024

CLA added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant