Update jax.scipy.special.gamma and gammasgn to return NaN for negativ… #24945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkinsp
force-pushed
the
gamma
branch
3 times, most recently
from
0bbed65
to
eeae515
Compare
|
Looks good, but also looks like some unrelated changes snuck in? |
I don't think so? I'm now using |
Is that necessary? In several other places we use the Line 39 in 65f9c78 |
I think we can/should delete that utility, but ok let's save that for another change. |
jakevdp
approved these changes
Nov 18, 2024
google-ml-butler
bot
added
kokoro:force-run
pull ready
…e integer inputs. Change to match upstream scipy: scipy/scipy#21827. Fixes jax-ml#24875
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e integer inputs.
Change to match upstream scipy: scipy/scipy#21827.