Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Deprecated abc Decorators (#1) #314

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pixeeai
Copy link

@pixeeai pixeeai commented Nov 8, 2024

The @abstractproperty, @abstractclassmethod, and @abstractstaticmethod decorators from abc has been deprecated since Python 3.3. This is because it's possible to use @property, @classmethod, and @staticmethod in combination with @abstractmethod.

Our changes look like the following:

 import abc

 class Foo:
-   @abc.abstractproperty
+   @property
+   @abc.abstractmethod
    def bar():
        ...

and similarly for @abstractclassmethod and @abstractstaticmethod.

More reading

@pixeeai
Copy link
Author

pixeeai commented Nov 8, 2024

FYI - This change was autogenerated from a GitHub app - called Pixeebot. A code-quality GitHub App; like Dependabot, but for source code. Feel free to check it our for more details for how you can install it onto your project's repo for continued code hardening and code security recommendations.

Copy link

google-cla bot commented Nov 8, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pixeeai pixeeai reopened this Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant