Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package.toString() not working in JPF #466

Merged
merged 5 commits into from
Jun 28, 2024

Conversation

Harsh4902
Copy link
Contributor

  • I have created a test case in URLClassLoaderTest which is failing because Pcakage.toString() method is not working and throwing NullPointerException

@cyrille-artho
Copy link
Member

Thanks. For the main branch, we wait with merging code until the test passes.

@Harsh4902
Copy link
Contributor Author

@cyrille-artho @pparizek I have changed the approach of loading package. We can access package by using object of Class class for current class. With this approach, we can further call Package.toString() method, which will not fail on JPF.

@cyrille-artho
Copy link
Member

Great! Can you please try to make the patch (in terms of changes) a bit smaller? For example, it's usually better to explicitly import the classes you need rather than using the wildcard, so the change from import java.util.A; import java.util.B; ... to import java.util.*; is not ideal. It also makes the patch bigger, which will make it harder to merge it into other branches.
Please check if you can do that (and push the changes again to this branch, which will auto-update the PR).

@cyrille-artho cyrille-artho merged commit 8d0e295 into javapathfinder:master Jun 28, 2024
2 checks passed
@cyrille-artho
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants