Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add object stream support for JPF on Java 11 #365

Merged
merged 8 commits into from
Jul 9, 2023
Merged

Add object stream support for JPF on Java 11 #365

merged 8 commits into from
Jul 9, 2023

Conversation

quadhier
Copy link
Collaborator

This patch should fix the issue that appears when ObjectInputStream reads an object thus adding object stream API support for JPF on Java 11.

It should fix the following failing test mentioned in #274 and bring no more regressions.

gov.nasa.jpf.test.java.io.ObjectStreamTest::testSimpleReadbackOk

After this patch, there might be still 5 unit test failures left in JPF on Java 11.

Copy link
Member

@cyrille-artho cyrille-artho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Found a minor typo but otherwise looks good to me.

src/main/gov/nasa/jpf/jvm/JVMClassFileContainer.java Outdated Show resolved Hide resolved
@quadhier
Copy link
Collaborator Author

Looks good! Found a minor typo but otherwise looks good to me.

Thanks for your review, @cyrille-artho ! Hope you have a happy weekend and a pleasant holiday :P

@cyrille-artho cyrille-artho merged commit 5134596 into javapathfinder:java-10-gradle Jul 9, 2023
@cyrille-artho
Copy link
Member

Thanks a lot!

@quadhier quadhier deleted the object-stream-support branch July 9, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants