Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zip file support #158

Open
wants to merge 1 commit into
base: java-8
Choose a base branch
from
Open

Conversation

jtoman
Copy link
Contributor

@jtoman jtoman commented Aug 31, 2018

This is an initial implementation without any unit tests quite yet. This implementation has been tested on a spring framework-based application that uses the Zip file API. Before I write any unit tests I would like some feedback on how best to include a zip file in the unit tests.

@jtoman
Copy link
Contributor Author

jtoman commented Aug 31, 2018

#149

@cyrille-artho
Copy link
Member

If you would like to use an example .zip file that has fixed contents (such as one or two small text files) in it, the "canonical" location for a gradle-built project would be src/main/resources, as far as I know.

@gaurangkudale
Copy link
Contributor

Hi @cyrille-artho,
Can I work on this? If yes where should I add unit test and (one or two small text files)

@cyrille-artho
Copy link
Member

Yes, this would be very helpful, as it would show whether the patch works or not.
itoman wanted to add a unit test but somehow never got around do doing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants