Testing and docs #53
Open
Testing and docs #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cloned the project and while I was integrating the model with some other data pipeline I noticed there were no tests for the data_processor.py module.
I needed tests and also more specific docstrings about every method to ease the integration process with different data sources and data pipelines. This pull request is simply an addition of docstrings for all methods of data_processor.py and a new module test_data_processor.py wrote with unittest for unit testing data_processor.py. It could turn out to be useful for others that want to integrate this project with some other system and want to do proper integration testing.