Continuous integration on Windows and Linux #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI the test that is failing on Windows is related to issues regarding Potential solutions are described here (github.com/haskell/directory/issues/96), but were never merged. Edit: As suggested in haskell/win32/pull/129, adding a delay of 100 microseconds when deleting directories quickly on Windows fixes it. |
author Laurent P. René de Cotret <[email protected]> 1590583199 -0400 committer Laurent P. René de Cotret <[email protected]> 1592074443 -0400 Updated CI workflow
|
Thanks, this is awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request is an extension of #779, following the discussion in #782.
The only change is related to the GH Workflow file, which configures CI on both Linux and Windows. Contrary to #779 , I can confirm that the CI works correctly.
This PR also activates CI builds for other PRs, so that the problem does not repeat :).
One thing to note. As mentioned in #782, CI builds on Windows using GHC 8.8.1 - 8.8.3 do not work reliably. See here and here. Therefore, until fixes are backported from GHC 8.10.*, Windows builds are using GHC 8.6.5.