Port to new bytestring builder #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to use more efficient conversions during rendering and avoids building intermediate strings.
It is unnecessary to escape them as all attributes are enclosed in double-quotes. For a detailed discussion, see jaspervdj/blaze-html#48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jasper,
here's a port to the new bytestring builder. It also fixes the request on not escaping single-quotes and slightly improves performance for decimally encoding
Ints. Note that the new bytestring builder is not yet completely finished (i.e., there are patches in my repo that got lost during the hustle of releasing the new bytestring package from its darcs repo). We can expect further improvements forIntegerencoding and the like once these patches have been integrated.best regards,
Simon