Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add temporary call to library so that kknn classification does not crash #9

Closed
wants to merge 1 commit into from
Closed

Add temporary call to library so that kknn classification does not crash #9

wants to merge 1 commit into from

Conversation

koenderks
Copy link
Collaborator

@koenderks koenderks commented Jan 23, 2021 •
edited
Loading

@vandenman @JorisGoosen Not sure if we should do this, but made the PR in case you guys think this is a good temporary solution.

Issue: https://github.com/jasp-stats/INTERNAL-jasp/issues/1227

@koenderks koenderks requested a review from vandenman January 23, 2021 13:29
@JorisGoosen
Copy link
Contributor

This could be a good solution if:

  • It solves the problem ;)
  • It would add time to engine-startup if we put it there
    Because that is also an option, calling that during initialization of the engine.

@JorisGoosen
Copy link
Contributor

I've made a PR that loads kknn on startup: jasp-stats/jasp-desktop#4453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vandenman vandenman Awaiting requested review from vandenman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koenderks @JorisGoosen