Skip to content
This repository has been archived by the owner on Oct 29, 2022. It is now read-only.

Remove non-vanilla * from helper and denial systems #336

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jasonw4331
Copy link
Owner

Introduction

Recently it was pointed out to me that @a would be better to be used in place of the asterisk * because Vanilla bedrock edition uses the @a selector. I agree.

The plugin PlayerSelectors on poggit can be used to add the @a selector along with many other vanilla selectors. This PR removes the * implementation in a push for users to use the PlayerSelectors plugin instead.

Relevant issues

  • N/A

Changes

API changes

  • The asterisk * can no longer be used with Plot::isHelper() or Plot::isDenied()

Behavioral changes

  • The addhelper subcommand can no longer use the asterisk * to open a plot to everyone
  • The denyplayer subcommand can no longer use the asterisk * to block everyone from a plot

Backwards compatibility

  • Upon updating, plots that had everyone blocked and plots that had everyone helping will no longer function as expected.

Follow-up

  • All Following releases should advertise PlayerSelectors as a replacement for the feature.

Tests

The asterisk* no longer functions to allow or block all players.

@jasonw4331 jasonw4331 added Category: Feature Request This feature may or may not be added in the future Priority: Low Status: Work In Progress BC-Breaks This pertains to backwards compatibility breaks in the API labels Sep 16, 2020
@jasonw4331 jasonw4331 self-assigned this Sep 16, 2020
@Thunder33345
Copy link

Thunder33345 commented Sep 16, 2020

The addhelper subcommand can no longer use the asterisk * to open a plot to everyone
The denyplayer subcommand can no longer use the asterisk * to block everyone from a plot

what's a valid new replacement or an alternative for a wildcard allow/block?
assuming @a only applies to currently online players

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
BC-Breaks This pertains to backwards compatibility breaks in the API Category: Feature Request This feature may or may not be added in the future Priority: Low Status: Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants