Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add next and previous lunar phase methods #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danthareja
Copy link

This is super random, but I was looking for some code to find the date for the next full moon and came across your project.

Instead of re-inventing the wheel, I decided to fork your work and thought I'd submit a PR back.

@jasonsturges
Copy link
Owner

@danthareja Hi, appreciate this. My solution is always off by 2-hours, which I haven't had a chance to fully debug.

API is great, but I'm not sure this hits the exact hour and minute? Let me scope this out, and revisit why my solution was off.

@sbsmatt
Copy link

sbsmatt commented Jun 27, 2021

I'm also here for next phase, and next phase date.
That's usually the next thing people want to see after the current phase.

@danthareja
Copy link
Author

@jasonsturges thanks for the review.

I did notice some interesting behavior when testing the timings of this latest full moon.

The current calculation is good enough for my very naive use at the moment, but I am curious to hear if the timings can be tightened up a bit.

@jasonsturges
Copy link
Owner

@danthareja Sorry, been through an epic saga of buying a home and moving. Sure you've probably incorporated something into your solution - hopefully this helped give you a start. Getting back into the swing of things and will pick this up.

@danthareja
Copy link
Author

Totally understand man, real life should always take priority over free open source side projects.

I am still curious if you do figure out something here but absolutely no stress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants