Update scanner.py #521
Update scanner.py #521
Conversation
Here’s a modified version of the send_discovery_request function to include debugging and exception handling:
| iface['socket'].bind((address, 0)) | ||
| except socket.gaierror as e: | ||
| print(f"Failed to bind to {address}: {e}") | ||
| continue |
There was a problem hiding this comment.
Thanks for this PR @blitzu ! I'm wondering, why use print() instead of log.debug() and log.error() here?
There was a problem hiding this comment.
this is what chatgpt gave me. i had an error on using scanner.py and this was the solution from chatgpt and it works
|
I'm gonna vote "no" for this one. PR #519 already fixes the underlying problem (instead of just hiding the error), print() should not be used here, and I like my spaces 🤣 |
Ha! I didn't even see them until @blitzu's PR. We could use a style guide helper. I'm tempted to cherry pick just the spaces fix for this PR. 😝
That's true. I need to merge that and get into a minor rev release. @blitzu even though this PR will be addressed with #519 , we appreciate you raising this! Active community members and willing contributors like you are how we keep the project moving forward. Thank you! |
|
Personally I like having spaces inside brackets/parenthesis as I find it a lot more readable when scanning through code. |
|
Full fix in #519. |
Here’s a modified version of the send_discovery_request function to include debugging and exception handling: