Added basestring check to image.py #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t behind by me), using basestring defined in commit instead of six.string_types. Future versions could use possibly Six.string_types or future.utils version of string_types
|
Seems all tests from the travis-ci failed at: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed errors when using Python3.6 when the Image.resize() method did a instance check on
basestring. I noted in the commit message that a possibility would be to continue using the try..catch statement to define basestring if it doesn't exist, but the option remains of using packages likesixandfuture.utils. However this would mean importing more packages which would be inefficient for just a basestring implementation/replacement.