Basic CTL shared_ptr implementation #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Supersedes #1229. |
Also just use plain using statements, derp
Needed for the placement-new in shared_emplace to compile properly.
A shared_ptr<void> is not anonymous, it's just a wrapped void*.
Put a noexcept annotation on drop_shared (since dispose is also noexcept for now) and simplify reset, fixing a bug in weak_ptr::swap.
jart
approved these changes
Aug 31, 2024
| __atomic_fetch_add(r, 1, __ATOMIC_RELAXED); | ||
| #else | ||
| size_t refs = __atomic_fetch_add(r, 1, __ATOMIC_RELAXED); | ||
| if (refs > ((size_t)-1) >> 1) |
There was a problem hiding this comment.
Is there any particular reason why you wouldn't just use long and then check if it's negative?
There was a problem hiding this comment.
You’d need ckd_add or something in that case - I believe signed integer overflow is UB
There was a problem hiding this comment.
Oh wait, no, I see what you mean. Yeah, that could work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.