switching to xml parsing for better handling of animation #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… inkscape layer each frame, no more need for footer module as etree takes care of xml
… has the ability to write svg header if it does not yet exists. this way you have at most just 3 modules to load
|
got rid of svg_header.py too. Now all 3 remaining modules can write a SVG header if they find it is not already existing. |
…e edges in SVG with color and thickness according to values passed by freestyle shaders, allowing to achieve more complex effects. Made hardcoded values for color and thickness in other modules easier to edit by the user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello Jarno,
I'm suggesting quite a radical change: I've introduced the use of xml.etree for svg parsing and handling.
It allows to get rid of footer module, and now animation frames are rendered as Inkscape layers inside a single file, making cleaner and easier postprocessing and management.
what do you think about it?
best, francesco