-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for placeholder text #140
base: master
Are you sure you want to change the base?
Conversation
Closes #136 |
Any movement on this PR? looks like an excellent addition @jaredreich? |
|
@jaredreich any news on this PR? Looks mighty useful for the community - perhaps you have some concerns which @KhodorAmmar can address? |
I can see a conflict in the demo.html now, but i can update if the maintainer is happy with the edits |
@jaredreich FWIW, I am using @KhodorAmmar's code in a fork in production right now. |
Hmm, as the linked #174 shows, it's not necessarily the case that "conceptually blank" maps very well to css Wouldn't a better alternative be for pell to set some marker class Possibly even simpler to implement and reason about, and potentially good enough for a placeholder might be a concept |
Hello , any chance this gets merged anytime soon ? |
+1 I would also like this to get merged |
Apologies to everyone waiting for this. I'm planning to give pell some love very soon. |
I was looking for a program that produced skinny html and Pell is the best I have found so far. Here are my reasons:
The future:
|
I'm also in favour of this |
Code works as expected! Good job! Please merge someone :D |
This sounds great! When can this be merged? |
Would love this to be merged! |
@jaredreich is there a timeline on resolving this? |
Does anyone know if it's possible to fork Pell and then pull some of these requests in? I think our god has abandoned us. |
yeah you can just do it and maintain your own fork
…On Tue, 30 Nov 2021 at 02:37, VaelVictus ***@***.***> wrote:
Does anyone know if it's possible to fork Pell and then pull some of these
requests in? I think our god has abandoned us.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#140 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABVORO4HJWTI6XFZZUN5VLUOQ2FLANCNFSM4FGS2N4Q>
.
--
________________________________
ꜽ . antony jones . http://www.enzy.org
|
Adds a new default options "placeholder".
Adding a placeholder will add a data-placeholder attribute on the contenteditable area.
Using css's
:empty
show and hide the "placeholder" text on the content area.