Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --ignore option to the library #28

Closed
wants to merge 9 commits into from

Conversation

etagwerker
Copy link

Hi @jaredbeck,

This PR fixes #27 by adding a --ignore option to the library.

Any user will be able to ignore specific gems from their report.

Please check it out and let me know what you think.

Thanks,
Ernesto

@jaredbeck jaredbeck self-requested a review January 21, 2024 17:53
Copy link
Owner

@jaredbeck jaredbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great, but seems that tests are failing? Please rebase and push to re-run CI.

@etagwerker
Copy link
Author

@jaredbeck Thanks for the quick review! ❤️

I've been testing with Ruby 3.1 and it seems to work fine locally.

Unfortunately I can't find the error in the check that is associated with this commit: 546dc75 -- it seems like a usability problem with GH actions or maybe I'm not looking in the right place...

I merged master into this branch and updated it. Could you please approve the workflow? Maybe then I'll be able to see the error...

@jaredbeck
Copy link
Owner

Could you please approve the workflow?

Approved. Also, I think I've now configured it so it won't require approval again. 🤞

This will make it easier to test the new ignore option
This will allow the user to filter gems that are not desired in the report
This will test the run method with and without the ignore option
Make sure that we filter the list of gems before we pass it to the Report instance
Copy link

This PR has been automatically marked as stale due to inactivity.
The resources of our volunteers are limited.
If this is something you are committed to continue working on, please address any concerns raised by review and/or ping us again.
Thank you for all your contributions.

@github-actions github-actions bot added the Stale label Jun 15, 2024
@github-actions github-actions bot closed this Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inaccurate libyears total for a Rails application
2 participants