-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --ignore option to the library #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great, but seems that tests are failing? Please rebase and push to re-run CI.
@jaredbeck Thanks for the quick review! ❤️ I've been testing with Ruby 3.1 and it seems to work fine locally. Unfortunately I can't find the error in the check that is associated with this commit: 546dc75 -- it seems like a usability problem with GH actions or maybe I'm not looking in the right place... I merged |
Approved. Also, I think I've now configured it so it won't require approval again. 🤞 |
This will make it easier to test the new ignore option
This will allow the user to filter gems that are not desired in the report
This will test the run method with and without the ignore option
Make sure that we filter the list of gems before we pass it to the Report instance
552193a
to
d037ca4
Compare
This PR has been automatically marked as stale due to inactivity. |
Hi @jaredbeck,
This PR fixes #27 by adding a
--ignore
option to the library.Any user will be able to ignore specific gems from their report.
Please check it out and let me know what you think.
Thanks,
Ernesto