Skip to content

Commit

Permalink
Merge pull request #40 from fatkodima/fix-duplicate-reports
Browse files Browse the repository at this point in the history
Report problematic release dates only once per gem name
  • Loading branch information
jaredbeck authored Sep 14, 2024
2 parents 3c68d67 + 5cb23e4 commit c626b0c
Showing 1 changed file with 16 additions and 7 deletions.
23 changes: 16 additions & 7 deletions lib/libyear_bundler/models/gem.rb
Original file line number Diff line number Diff line change
Expand Up @@ -23,23 +23,32 @@ def release_date(gem_name, gem_version)
begin
dep = ::Bundler::Dependency.new(gem_name, gem_version)
rescue ::Gem::Requirement::BadRequirementError => e
$stderr.puts "Could not find release date for: #{gem_name}"
$stderr.puts(e)
$stderr.puts(
"Maybe you used git in your Gemfile, which libyear doesn't support " \
"yet. Contributions welcome."
)
report_problem(gem_name, <<-MSG)
Could not find release date for: #{gem_name}
#{e}
Maybe you used git in your Gemfile, which libyear doesn't support yet. Contributions welcome.
MSG
return nil
end
tuples, _errors = ::Gem::SpecFetcher.fetcher.search_for_dependency(dep)
if tuples.empty?
$stderr.puts "Could not find release date for: #{gem_name}"
report_problem(gem_name, "Could not find release date for: #{gem_name}")
return nil
end
tup, source = tuples.first # Gem::NameTuple
spec = source.fetch_spec(tup) # raises Gem::RemoteFetcher::FetchError
spec.date.to_date
end

private

def report_problem(gem_name, message)
@reported_gems ||= {}
@reported_gems[gem_name] ||= begin
$stderr.puts(message)
true
end
end
end

def installed_version
Expand Down

0 comments on commit c626b0c

Please sign in to comment.