Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] React 18 support #1068

Draft
wants to merge 53 commits into
base: master
Choose a base branch
from
Draft

[WIP] React 18 support #1068

wants to merge 53 commits into from

Conversation

japgolly
Copy link
Owner

@japgolly japgolly commented May 27, 2022 •
edited by rpiaggio
Loading

Addresses #1057

japgolly
japgolly commented May 27, 2022
View reviewed changes
library/project/Dependencies.scala
/ "umd/react-dom-server.browser.development.js"
minified "umd/react-dom-server.browser.production.min.js"
/ "umd/react-dom-server-legacy.browser.development.js"
minified "umd/react-dom-server-legacy.browser.production.min.js"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Report this to React

This was referenced May 27, 2022
Closed
Closed
@japgolly
Copy link
Owner Author

LegacyReactTestUtils breaks semver you idiot

@japgolly japgolly changed the title React 18 support [WIP] React 18 support May 30, 2022
@rpiaggio rpiaggio marked this pull request as ready for review January 29, 2024 18:02
@rpiaggio
Copy link
Collaborator

Although React 18 support is not complete yet, we have a large application with only functional components which we were able to upgrade with the changes so far. Let's cut a beta release with this and aim to implement the rest of the functionality.

@rpiaggio rpiaggio marked this pull request as draft January 29, 2024 18:07
@rpiaggio
Copy link
Collaborator

I'll attempt to make the release without merging into master.

@ngbinh
Copy link

ngbinh commented Feb 9, 2024

Thanks @rpiaggio for making progress on this. Would love to help but not sure what are the remaining items

@rpiaggio
Copy link
Collaborator

Thanks @rpiaggio for making progress on this. Would love to help but not sure what are the remaining items

Hi @ngbinh ! You can see the checklist that @japgolly made here: #1057

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@japgolly @rpiaggio @ngbinh @hugo-vrijswijk