Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dynamic wrapper for nexus-repository-manager plugin #1738

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JessicaJHee
Copy link
Member

Description

Adds dynamic wrapper for nexus-repository-manager plugin after its migration to the community-plugins repo.

Which issue(s) does this PR fix

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

@JessicaJHee JessicaJHee requested a review from a team as a code owner October 7, 2024 20:27
Copy link
Contributor

github-actions bot commented Oct 7, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1738!

@JessicaJHee
Copy link
Member Author

/retest

@04kash
Copy link
Member

04kash commented Oct 10, 2024

/lgtm

@04kash 04kash force-pushed the nexus-repository-manager-wrapper branch from 028269a to 8ce4b2e Compare October 10, 2024 20:33
@openshift-ci openshift-ci bot removed the lgtm label Oct 10, 2024
Copy link

sonarcloud bot commented Oct 10, 2024

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1738!

@04kash
Copy link
Member

04kash commented Oct 10, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 10, 2024
Copy link

openshift-ci bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 04kash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Oct 10, 2024

@JessicaJHee: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests 8ce4b2e link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@04kash
Copy link
Member

04kash commented Oct 11, 2024

The e2e-tests seem to be failing 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants