Remove CommonJSLoader bug workaround

Signed-off-by: David Festal <[email protected]>
janus-idp · Jan 23, 2024 · c6c380d · c6c380d
1 parent 2e6adaa
commit c6c380d
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 63 deletions.
diff --git a/packages/backend/src/index.ts b/packages/backend/src/index.ts
@@ -44,13 +44,7 @@ import {
  gatherDynamicPluginsSchemas,
 } from './schemas';
 
-// TODO(davidfestal): The following import is a temporary workaround for a bug
-// in the upstream @backstage/backend-dynamic-feature-service package.
-//
-// It should be removed as soon as the upstream package is fixed and released.
-// see https://github.com/janus-idp/backstage-showcase/pull/600
 import { WinstonLogger } from '@backstage/backend-app-api';
-import { CommonJSModuleLoader } from './loader/CommonJSModuleLoader';
 
 function makeCreateEnv(config: Config, pluginProvider: BackendPluginProvider) {
  const root = getRootLogger();
@@ -143,7 +137,6 @@ async function main() {
  const pluginManager = await DynamicPluginManager.create({
  config,
  logger,
- moduleLoader: new CommonJSModuleLoader(logger),
  });
 
  const dynamicPluginsSchemas = await gatherDynamicPluginsSchemas(

diff --git a/packages/backend/src/loader/CommonJSModuleLoader.ts b/packages/backend/src/loader/CommonJSModuleLoader.ts