chore(release): [1.2] verifying plugins have been released to npmjs.com and bumping versions #2350
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fortune-Ndlovu
changed the title
Fortune-Ndlovu
changed the title
nickboldt
reviewed
Oct 11, 2024
plugins/acr/package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@janus-idp/backstage-plugin-acr", | |||
| "version": "1.4.11", | |||
| "version": "1.7.11", | |||
There was a problem hiding this comment.
the version in the 1.3 branch is ALSO at 1.7.11 so this will collide. https://github.com/janus-idp/backstage-plugins/blob/release-1.3/plugins/acr/package.json#L3
however 1.7.z is the correct version for the 1.3 branch, as main has moved ACR to https://github.com/backstage/community-plugins/commits/main/workspaces/acr/plugins/acr/package.json where it's at version 1.8.z
Should this be at 1.6.z in 1.2?
Suggested change
| "version": "1.7.11", | |
| "version": "1.6.4", |
There was a problem hiding this comment.
I missed the version in other branches, your right that makes sense based on the current versioning across the branches. That is:
- main branch 1.8.z (already moved to community-plugins repo)
- release-1.3 branch 1.7.z (currently at 1.7.11, which is correct for this branch)
- 1.2.x branch Since 1.7.11 is used in 1.3, and 1.8.z is in the main branch, the 1.2.z branch should have a version that's lower than 1.7.z to avoid conflicts (Logically speaking, your right). Hence 1.6.4 in 1.2.z
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/RHIDP-4217
Bumping plugin versions based on the npm registry and previous release.