Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update icon colors #33

Merged
merged 11 commits into from
Mar 27, 2020
Merged

Update icon colors #33

merged 11 commits into from
Mar 27, 2020

Conversation

Madis0
Copy link
Contributor

@Madis0 Madis0 commented Mar 25, 2020 •
edited
Loading

Fixes #32

@jannispinter
Copy link
Owner

We need to update the colors used in the resources tab as well. Those are defined in the protocolColorMap in popup/popup.js. I'm going to swap them in a minute.

@jannispinter
Update popup.js
d500c57 
Change colors in resource tab according to the new icons
@jannispinter
Copy link
Owner

I left the bright green color for TLSv1.3 in place for the resource tab. What do you think, shall we merge it?

@jannispinter jannispinter added the enhancement New feature or request label Mar 26, 2020
@Madis0
Copy link
Contributor Author

Madis0 commented Mar 26, 2020

We should remove SSL v3 and readd the warning icon first.

@jannispinter
Copy link
Owner

Thank you @Madis0!

I will test this via temporary extension side-loading today (about:debugging#/runtime/this-firefox). If everything works as expected, I'll release it as version 0.2 tonight.

Madis0
Madis0 commented Mar 26, 2020
View reviewed changes
background.js Outdated Show resolved Hide resolved
@Madis0 Madis0 marked this pull request as ready for review March 26, 2020 08:22
@jannispinter jannispinter merged commit 76af6b9 into jannispinter:master Mar 27, 2020
@Madis0 Madis0 deleted the icon-update branch March 28, 2020 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannispinter jannispinter jannispinter left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New default coloring
2 participants
@Madis0 @jannispinter