Allow nested entities to be interaction targets #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janhohenheim
requested changes
Mar 1, 2024
There was a problem hiding this comment.
Thanks!
Two little things left:
- Remove the .swp file
- Make the system run after TransformPropagate.
|
Good catches, thanks! |
|
Looks good now, merging after CI :) Edit: Looks like there's a missing comma |
janhohenheim
approved these changes
Mar 1, 2024
janhohenheim
requested changes
Mar 1, 2024
|
Yeah... Hey at least I know how to run the linter now |
janhohenheim
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue discussed in the Discord where nested entities don't work correctly as interaction targets. This was due to the code using Transform instead of GlobalTransform. I tested that Follower interaction still works after this change.