Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #1709 #57

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Backport #1709 #57

merged 3 commits into from
Apr 30, 2024

Conversation

ncik-roberts
Copy link
Contributor

Backport ocaml/merlin#1709 to fix misleading type errors like this:

type t = {
    foo : int
    bar : baz
}

(*
A type variable is unbound in this type declaration.
In field foo: 'a the variable 'a is unbound
*)

@liam923 please merge once you review this.

@ncik-roberts ncik-roberts requested a review from liam923 April 30, 2024 01:49
Copy link
Contributor

@liam923 liam923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'll wait until #58 merges to merge because if there's conflicts, they'll be easier to resolve in this PR.

@liam923 liam923 merged commit 25ccbc0 into main Apr 30, 2024
1 of 2 checks passed
@ncik-roberts ncik-roberts deleted the backport-1709 branch May 1, 2024 02:34
@liam923 liam923 mentioned this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants