Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mac legacy runner to macos-13 #3436

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

softins
Copy link
Member

@softins softins commented Dec 6, 2024

Short description of changes

Update the build runner for Mac legacy from macos-12 to macos-13. The version of xcode is left unchanged at 14.2.0, as this is still supported on macos-13.

CHANGELOG: Build: Updated the Github build runner for MacOS Legacy to macos-13

Context: Fixes an issue?

The macos-12 runner has been discontinued by Github, as mentioned in #3433. This PR fixes the MacOS Legacy build.

Does this change need documentation? What needs to be documented and how?

Not really.

Status of this Pull Request

Tested and working. I've installed the image built with this change and it appears to work fine.

What is missing until this pull request can be merged?

Nothing

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors. (except iOS)
  • I've filled all the content above

Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legacy also works on macOS 15.1.1

@ann0see ann0see added this to the Release 3.12.0 milestone Dec 6, 2024
@softins softins requested a review from pljones December 9, 2024 16:41
Copy link
Collaborator

@pljones pljones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't say whether this is right in any way other than it changes "12" to "13" in two places.

@softins softins merged commit e194011 into jamulussoftware:main Dec 9, 2024
11 of 12 checks passed
@softins softins deleted the update-mac-legacy-build branch December 9, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants