Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Text tags to Box to get rid of <div> cannot appear inside <p> warnings #106

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Change Text tags to Box to get rid of <div> cannot appear inside <p> warnings #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78ee60c
These Text tags contain more than text, use Box
asiansteev Jul 10, 2020
8513440
Text tag contains more than text, use Box
asiansteev Jul 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/Hero.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,13 @@ const Hero = ({ padding, title, subtitle }) => {
>
{title}
</Text>
<Text
<Box
color="snow"
mt={["16px", "12px"]}
fontSize={["20px", "24px", "28px", "31px", "38px"]}
>
{subtitle}
</Text>
</Box>
</Box>
</PseudoBox>
)
Expand Down
4 changes: 2 additions & 2 deletions src/pages/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ const Home = ({ data }) => {
a company donates, it chooses to spend a percent of its money. We
can compare these two numbers:
</Text>
<Text
<Box
color="snow"
fontSize={["20px", "22px", "24px", "26px", "30px"]}
display="flex"
Expand All @@ -253,7 +253,7 @@ const Home = ({ data }) => {
&times; your income<span className="space">&nbsp;</span>
</PseudoBox>
<PseudoBox textAlign="left">= your donation</PseudoBox>
</Text>
</Box>
<PseudoBox
color="primary.green"
fontWeight="700"
Expand Down