Skip to content

Commit

Permalink
Bug 1895867 [wpt PR 46183] - Revert "webnn: Enforce input data type c…
Browse files Browse the repository at this point in the history
…onstraints for gather indices", a=testonly

Automatic update from web-platform-tests
Revert "webnn: Enforce input data type constraints for gather indices"

This reverts commit ef29e11bfb1f1f4eae0935fb58f0e4129620837b.

Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5728899092709376

Sample build with failed test: https://ci.chromium.org/b/8748452022241283393
Affected test(s):
[ninja://services:services_unittests/WebNNGraphImplBackendTest.BuildAndComputeSingleOperatorGather](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fservices:services_unittests%2FWebNNGraphImplBackendTest.BuildAndComputeSingleOperatorGather?q=VHash%3A3db3852ce13cc70a)

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5728899092709376&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5520313&type=BUG

Original change's description:
> webnn: Enforce input data type constraints for gather indices
>
> As specified in webmachinelearning/webnn#646
>
> Bug: 328567884
> Change-Id: I33eba7e1def430b1cb94e3e7a4868e82c5bbd9a3
> Cq-Include-Trybots: luci.chromium.try​:mac14-blink-rel,mac14.arm64-blink-rel
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5520313
> Reviewed-by: Austin Sullivan <[email protected]>
> Commit-Queue: Lisha Guo <[email protected]>
> Reviewed-by: ningxin hu <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1298443}
>

Bug: 328567884
Change-Id: Iab874e915f5603861929cdf07ba4c09698b76503
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5528819
Reviewed-by: Austin Sullivan <[email protected]>
Reviewed-by: Phillis Tang <[email protected]>
Commit-Queue: Austin Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1298718}

--

wpt-commits: 61d40184e4b3d7aa0cca8c16cf3488e248c3ff04
wpt-pr: 46183
  • Loading branch information
[email protected] authored and moz-wptsync-bot committed May 21, 2024
1 parent 8898846 commit 5a45f1c
Showing 1 changed file with 4 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const tests = [
{
name: '[gather] Test gather with default options and 0-D indices',
input: {dataType: 'int32', dimensions: [3]},
indices: {dataType: 'int64', dimensions: []},
indices: {dataType: 'uint64', dimensions: []},
output: {dataType: 'int32', dimensions: []}
},
{
Expand All @@ -24,23 +24,15 @@ const tests = [
indices: {dataType: 'int64', dimensions: [1]}
},
{
name:
'[gather] TypeError is expected if the axis is greater than the rank of input',
name: '[gather] TypeError is expected if the axis is greater than the rank of input',
input: {dataType: 'float16', dimensions: [1, 2, 3]},
indices: {dataType: 'uint32', dimensions: [5, 6]},
indices: {dataType: 'int32', dimensions: [5, 6]},
axis: 4
},
{
name:
'[gather] TypeError is expected if the data type of indices is float32 which is invalid',
name: '[gather] TypeError is expected if the data type of indices is invalid',
input: {dataType: 'float16', dimensions: [1, 2, 3, 4]},
indices: {dataType: 'float32', dimensions: [5, 6]}
},
{
name:
'[gather] TypeError is expected if the data type of indices is int32 which is invalid',
input: {dataType: 'float16', dimensions: [1, 2, 3, 4]},
indices: {dataType: 'int32', dimensions: [5, 6]}
}
];

Expand Down

0 comments on commit 5a45f1c

Please sign in to comment.