Remove unnecessary compatibility shims #72
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type bytes is available on all supported Pythons. On Python 2.7, it is an alias for str, same as six.binary_type. Likewise, io.BytesIO is available on all supported Pythons. It is always a stream implementation using an in-memory bytes buffer. Byte literals and Unicode literals are available on all supported Pythons. Makes the code more forward compatible with Python 3.
|
Rebased to resolve merge conflicts. |
|
Just to let you know - i do appreciate the patches, i'm just not all that worried about removing old compatibility stuff until there's something we can't support. I know they're deprecated, but i don't see keeping the code there as a support problem for now so haven't really felt the need to drop it. |
|
May you reconsider this ? |
|
I've proposed an intermediate PR: |
|
Out of date (obviously), took the commit as part of #248. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type bytes is available on all supported Pythons. On Python 2.7, it
is an alias for str, same as six.binary_type.
Likewise, io.BytesIO is available on all supported Pythons. It is always
a stream implementation using an in-memory bytes buffer.
Byte literals and Unicode literals are available on all supported
Pythons.
Makes the code more forward compatible with Python 3.