Replace the last use of pbr with modern packaging #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the one last use of pbr in Sphinx configuration with the modern
combination of importlib.metadata (builtin) + packaging. Besides
avoiding the dependency, it fixes handling VCS versions, that make pbr
crash:
```
Traceback (most recent call last):
File "/tmp/requests-mock/.tox/docs/lib/python3.12/site-packages/sphinx/config.py", line 358, in eval_config_file
exec(code, namespace) # NoQA: S102
^^^^^^^^^^^^^^^^^^^^^
File "/tmp/requests-mock/doc/source/conf.py", line 59, in <module>
version = version_info.version_string()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/requests-mock/.tox/docs/lib/python3.12/site-packages/pbr/version.py", line 505, in version_string
return self.semantic_version().brief_string()
^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/requests-mock/.tox/docs/lib/python3.12/site-packages/pbr/version.py", line 498, in semantic_version
self._semantic = self._get_version_from_importlib_metadata()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/requests-mock/.tox/docs/lib/python3.12/site-packages/pbr/version.py", line 483, in _get_version_from_importlib_metadata
return SemanticVersion.from_pip_string(result_string)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/requests-mock/.tox/docs/lib/python3.12/site-packages/pbr/version.py", line 156, in from_pip_string
return klass._from_pip_string_unsafe(version_string)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/requests-mock/.tox/docs/lib/python3.12/site-packages/pbr/version.py", line 226, in _from_pip_string_unsafe
dev_count = int(component[3:])
^^^^^^^^^^^^^^^^^^
ValueError: invalid literal for int() with base 10: '63+gfba8cc7'
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the one last use of pbr in Sphinx configuration with the modern combination of importlib.metadata (builtin) + packaging. Besides avoiding the dependency, it fixes handling VCS versions, that make pbr crash: