Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating eScience #46

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

danielskatz
Copy link
Contributor

No description provided.

@vsoch
Copy link
Collaborator

vsoch commented Nov 28, 2019

Previous should be a list I believe, since there will ultimately be more than one.

@danielskatz
Copy link
Contributor Author

I had the - there first, but the check failed, so I removed it since it wasn't a list, and it seems the check still fails.

@vsoch
Copy link
Collaborator

vsoch commented Nov 28, 2019

I think it’s missing from the test, which is my fault! If it’s ok with you, I can PR to add it. It makes sense for previous to be a list right?

@danielskatz
Copy link
Contributor Author

Yes, though if you want to make it a list, you probably should add another previous as well,
e.g.
https://www.escience2018.com
Amsterdam, Netherlands
2018-10-29
2018-11-01

@vsoch
Copy link
Collaborator

vsoch commented Nov 28, 2019

It’s failing because the YAML loader can’t load the new file - I think the TBA needs to be removed for next if there is an entry.

@vsoch
Copy link
Collaborator

vsoch commented Nov 28, 2019

Definitely!

@vsoch
Copy link
Collaborator

vsoch commented Nov 28, 2019

@danielskatz just a note that the current eScience doesn't have any previous entries, so I didn't fold that into the PR]to keep it scoped to adding the test. The current is:

name: eScience
link: https://escience-conference.org
next: TBA
# 2020 in Osaka, Japan

@danielskatz
Copy link
Contributor Author

See my PR on James’s repo

@vsoch
Copy link
Collaborator

vsoch commented Nov 28, 2019

Haha yes, I know, I was commenting that I didn't add it to the PR I just opened to add the test for a list.

@vsoch
Copy link
Collaborator

vsoch commented Nov 28, 2019

We are talking on said PR right now :)

@danielskatz
Copy link
Contributor Author

It’s thanksgiving

@vsoch
Copy link
Collaborator

vsoch commented Nov 28, 2019

Happy Thanksgiving! I don't understand the connection, but I'm good with throwing some turkeys into the conversation 🦃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants