-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating eScience #46
base: master
Are you sure you want to change the base?
Conversation
Previous should be a list I believe, since there will ultimately be more than one. |
I had the |
I think it’s missing from the test, which is my fault! If it’s ok with you, I can PR to add it. It makes sense for previous to be a list right? |
Yes, though if you want to make it a list, you probably should add another previous as well, |
It’s failing because the YAML loader can’t load the new file - I think the TBA needs to be removed for next if there is an entry. |
Definitely! |
@danielskatz just a note that the current eScience doesn't have any previous entries, so I didn't fold that into the PR]to keep it scoped to adding the test. The current is: name: eScience
link: https://escience-conference.org
next: TBA
# 2020 in Osaka, Japan |
See my PR on James’s repo |
Haha yes, I know, I was commenting that I didn't add it to the PR I just opened to add the test for a list. |
We are talking on said PR right now :) |
It’s thanksgiving |
Happy Thanksgiving! I don't understand the connection, but I'm good with throwing some turkeys into the conversation 🦃 |
No description provided.