Fixed issue with closeProgressThreshold for smaller bottom sheets #440
+172
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 27, 2024 17:15
When a ModalBottomSheets that due to its content is smaller than a full screen bottom sheet, the closeProgressThreshold is calculated based on how far the dialog has to move based on the percentage of the viewport/fullscreen dialog. We need to adjust for this based on the height difference of the viewport and the rendered content within the bottom sheet dialog Related issue: #jamesblasco#421
added 3 commits
January 14, 2025 07:32
By leveraging raw events from Listener instead of GestureDetector batteling in the GestureArena we are able to be less dependent on the Notification events to controll the dragging of the sheet and we can instead use vertical drag gestures directly to control the sheet. There is also added parameters to control the default scrollphysics of underlaying scrollable views, this lets us disable scrolling in the ScrollPhysics implementation from userspace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a ModalBottomSheets that due to its content is smaller than a full screen bottom sheet, the user has to move the dialog almost to the bottom of the screen before it dismisses. This is because the closeProgressThreshold calculates the threshold based on the viewport size and not the size of the rendered bottom sheet.
We need to adjust for this based on the height difference of the viewport and the rendered content within the bottom sheet dialog
Related issue: #421