-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward fix for wide gamut changes in colors #10
base: master
Are you sure you want to change the base?
Conversation
friendly ping @james-alex @isaacroberts |
Add an implementation of Color.toARGB32 to subclasses of Color
FYI, after upgrading my project to the new stable release Flutter 3.27.0, the underlying issue here resulted in build errors in my project. In my tests, @gaaclarke's PR here resolves these errors. Thus, this PR (or another similar fix) needs to be merged to resolve build incompatibilities between color_models and Flutter 3.27.0. In case it might help anyone in the meantime, I resolved my project's build errors with a dependency override pointing to gaaclarke's PR code (but substituting with my own fork), like so: dependencies:
color_models:
git:
url: https://github.com/gaaclarke/color_models.git
ref: wide-gamut
path: color_models
flutter_color_models:
git:
url: https://github.com/gaaclarke/color_models.git
ref: wide-gamut
path: flutter_color_models
dependency_overrides:
color_models:
git:
url: https://github.com/gaaclarke/color_models.git
ref: wide-gamut
path: color_models
flutter_color_models:
git:
url: https://github.com/gaaclarke/color_models.git
ref: wide-gamut
path: flutter_color_models |
fixes #9
changes:
I chose
fromValues
instead ofwithValues
since "with*" is used to mean tweaking an existing color, whereas that method is creating completely new color.