Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Comments #21

wants to merge 2 commits into from

Conversation

casakawa-jama
Copy link
Contributor

@casakawa-jama casakawa-jama commented Apr 23, 2020

Implements GET all comments endpoint

Returns: A single comment
"""
resource_path = 'comments/' + str(comment_id)
comments = self.__get_all(resource_path)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a single entity fetch

@@ -115,6 +115,30 @@ def get_baselines_versioneditems(self, baseline_id):
baseline_items = self.__get_all(resource_path)
return baseline_items

def get_comments(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add a boolean param for rootCommentsOnly

@@ -710,6 +734,37 @@ def post_item(self, project, item_type_id, child_item_type_id, location, fields,
JamaClient.__handle_response_status(response)
return response.json()['meta']['id']

def post_comment(self, item_id: int, message: str, in_reply_to: int = None):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need param to post to item or project. we should also add a field for comment type

Copy link
Member

@nmchale-jama nmchale-jama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments for requested updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants